feat(chat): show session-scoped reply failure details (#1255)

app/src/androidTest/java/com/m57/hermescontrol/ui/chat/components/ReplyErrorCardTest.kt

@@ -0,0 +1,139 @@
+package com.m57.hermescontrol.ui.chat.components
+
+import androidx.activity.ComponentActivity
+import androidx.compose.foundation.layout.Box
+import androidx.compose.foundation.layout.width
+import androidx.compose.ui.Modifier
+import androidx.compose.ui.semantics.SemanticsProperties
+import androidx.compose.ui.test.SemanticsMatcher
+import androidx.compose.ui.test.assert
+import androidx.compose.ui.test.assertIsDisplayed
+import androidx.compose.ui.test.assertIsEnabled
+import androidx.compose.ui.test.assertIsNotEnabled
+import androidx.compose.ui.test.junit4.createAndroidComposeRule
+import androidx.compose.ui.test.onNodeWithContentDescription
+import androidx.compose.ui.test.onNodeWithText
+import androidx.compose.ui.test.performClick
+import androidx.compose.ui.unit.dp
+import androidx.test.ext.junit.runners.AndroidJUnit4
+import com.m57.hermescontrol.R
+import com.m57.hermescontrol.theme.HermesControlTheme
+import com.m57.hermescontrol.ui.chat.ReplyFailure
+import org.junit.Assert.assertEquals
+import org.junit.Assert.assertFalse
+import org.junit.Rule
+import org.junit.Test
+import org.junit.runner.RunWith
+
+@RunWith(AndroidJUnit4::class)
+class ReplyErrorCardTest {
+    @get:Rule
+    val compose = createAndroidComposeRule<ComponentActivity>()
+
+    @Test
+    fun detailsStartCollapsedAndCopyIsScrubbedWithoutAutomaticSharing() {
+        var copied = ""
+        var shared = false
+        compose.setContent {
+            HermesControlTheme {
+                Box(Modifier.width(320.dp)) {
+                    ReplyErrorCard(
+                        failure = ReplyFailure("HTTP 429\nAuthorization: Bearer private-key"),
+                        onDismiss = {},
+                        onOpenLogs = {},
+                        onCopy = { copied = it },
+                        onShare = { shared = true },
+                    )
+                }
+            }
+        }
+        compose.onNodeWithText("HTTP 429", substring = true).assertDoesNotExist()
+
+        compose.onNodeWithText(compose.activity.getString(R.string.chat_reply_failed_details)).performClick()
+        compose.onNodeWithText("HTTP 429", substring = true).assertIsDisplayed()
+        compose.onNodeWithText("private-key", substring = true).assertDoesNotExist()
+        compose.onNodeWithText(compose.activity.getString(R.string.chat_reply_failed_copy)).performClick()
+        compose.runOnIdle {
+            assertEquals("HTTP 429\nAuthorization: [REDACTED]", copied)
+            assertFalse(shared)
+        }
+    }
+
+    @Test
+    fun sharingRequiresExpandedReviewAndUsesExactSanitizedPayload() {
+        var shared = ""
+        var logsOpened = 0
+        var dismissed = 0
+        compose.setContent {
+            HermesControlTheme {
+                ReplyErrorCard(
+                    failure = ReplyFailure("Provider failed\nAuthorization: Bearer private-token"),
+                    onDismiss = { dismissed++ },
+                    onOpenLogs = { logsOpened++ },
+                    onCopy = {},
+                    onShare = { shared = it },
+                )
+            }
+        }
+        compose.runOnIdle {
+            assertEquals("", shared)
+            assertEquals(0, logsOpened)
+            assertEquals(0, dismissed)
+        }
+        val detailsLabel = compose.activity.getString(R.string.chat_reply_failed_details)
+        val collapsedLabel = compose.activity.getString(R.string.chat_reply_failed_details_collapsed)
+        val expandedLabel = compose.activity.getString(R.string.chat_reply_failed_details_expanded)
+        val shareLabel = compose.activity.getString(R.string.chat_reply_failed_share)
+
+        compose
+            .onNodeWithText(detailsLabel)
+            .assert(SemanticsMatcher.expectValue(SemanticsProperties.StateDescription, collapsedLabel))
+        compose.onNodeWithText(shareLabel).assertIsNotEnabled().performClick()
+        compose.runOnIdle { assertEquals("", shared) }
+
+        compose.onNodeWithText(detailsLabel).performClick()
+        compose
+            .onNodeWithText(detailsLabel)
+            .assert(SemanticsMatcher.expectValue(SemanticsProperties.StateDescription, expandedLabel))
+        compose.onNodeWithText(shareLabel).assertIsEnabled().performClick()
+        compose.onNodeWithText(compose.activity.getString(R.string.chat_reply_failed_logs)).performClick()
+        compose
+            .onNodeWithContentDescription(
+                compose.activity.getString(R.string.chat_reply_failed_dismiss),
+            ).performClick()
+        compose.runOnIdle {
+            assertEquals("Provider failed\nAuthorization: [REDACTED]", shared)
+            assertEquals(1, logsOpened)
+            assertEquals(1, dismissed)
+        }
+    }
+
+    @Test
+    fun expandedReviewResetsForANewFailure() {
+        val failure = androidx.compose.runtime.mutableStateOf(ReplyFailure("First failure"))
+        compose.setContent {
+            HermesControlTheme {
+                ReplyErrorCard(
+                    failure = failure.value,
+                    onDismiss = {},
+                    onOpenLogs = {},
+                    onCopy = {},
+                    onShare = {},
+                )
+            }
+        }
+
+        val detailsLabel = compose.activity.getString(R.string.chat_reply_failed_details)
+        val collapsedLabel = compose.activity.getString(R.string.chat_reply_failed_details_collapsed)
+        val shareLabel = compose.activity.getString(R.string.chat_reply_failed_share)
+        compose.onNodeWithText(detailsLabel).performClick()
+        compose.onNodeWithText(shareLabel).assertIsEnabled()
+
+        compose.runOnIdle { failure.value = ReplyFailure("Second failure") }
+
+        compose
+            .onNodeWithText(detailsLabel)
+            .assert(SemanticsMatcher.expectValue(SemanticsProperties.StateDescription, collapsedLabel))
+        compose.onNodeWithText(shareLabel).assertIsNotEnabled()
+    }
+}