chore: eliminate all Kotlin compiler warnings in main source (#877)

* chore: eliminate all Kotlin compiler warnings in main source

* test(chat): fix cross-class coroutine leaks poisoning the unit suite

- ChatUpdateCommandTest: inject FakeSlashUsageStore — the real DataStore
  store inits on real IO threads with a relaxed-mock app (cacheDir NPE)
  and leaks an uncaught exception into the next runTest class.
- ChatUpdateCommandTest + SlashCommandDispatchRpcTest: mock
  ProfileSwitchCoordinator.switched (ChatViewModelTest pattern) — VMs
  otherwise park collectors on the singleton flow that crash later
  classes (ProfileSwitchCoordinatorTest) on stale-Main resumption.

Full suite: 944 tests, 0 failures (was 2 flaky per run).

---------

Co-authored-by: M57 <hy4ri@users.noreply.github.com>

app/src/main/java/com/m57/hermescontrol/data/update/AppUpdateChecker.kt

@@ -86,7 +86,7 @@ open class AppUpdateChecker(
                     .build()
             client.newCall(request).execute().use { response ->
                 if (!response.isSuccessful) return@use null
-                val body = response.body?.string().orEmpty()
+                val body = response.body.string().orEmpty()
                 parseUpdateInfo(body)
             }
         }
@@ -106,7 +106,7 @@ open class AppUpdateChecker(
             try {
                 client.newCall(request).execute().use { response ->
                     if (!response.isSuccessful) return@withContext false
-                    val body = response.body ?: return@withContext false
+                    val body = response.body
                     val total = body.contentLength()
                     dest.outputStream().use { out ->
                         val buffer = ByteArray(DEFAULT_BUFFER_SIZE)

app/src/main/java/com/m57/hermescontrol/data/ws/HermesWsClient.kt

@@ -303,7 +303,7 @@ object HermesWsClient {
             }
         if (socketToCancel != null) {
             rejectAllPending()
-            socketToCancel?.cancel()
+            socketToCancel.cancel()
         }
         if (shouldOpen) openSocket()
     }

app/src/main/java/com/m57/hermescontrol/data/ws/KanbanEventsClient.kt

@@ -153,7 +153,7 @@ class KanbanEventsClient {
                 request,
                 object : WebSocketListener() {
                     override fun onOpen(
-                        ws: WebSocket,
+                        webSocket: WebSocket,
                         response: Response,
                     ) {
                         if (closed || gen != generation) return
@@ -162,7 +162,7 @@ class KanbanEventsClient {
                     }
 
                     override fun onMessage(
-                        ws: WebSocket,
+                        webSocket: WebSocket,
                         text: String,
                     ) {
                         if (closed || gen != generation) return
@@ -173,20 +173,20 @@ class KanbanEventsClient {
                     }
 
                     override fun onMessage(
-                        ws: WebSocket,
+                        webSocket: WebSocket,
                         bytes: ByteString,
                     ) = Unit
 
                     override fun onClosing(
-                        ws: WebSocket,
+                        webSocket: WebSocket,
                         code: Int,
                         reason: String,
                     ) {
-                        ws.close(code, reason)
+                        webSocket.close(code, reason)
                     }
 
                     override fun onClosed(
-                        ws: WebSocket,
+                        webSocket: WebSocket,
                         code: Int,
                         reason: String,
                     ) {
@@ -199,7 +199,7 @@ class KanbanEventsClient {
                     }
 
                     override fun onFailure(
-                        ws: WebSocket,
+                        webSocket: WebSocket,
                         t: Throwable,
                         response: Response?,
                     ) {