Fix: Prevent AuthManager state pollution on connection verification (#348)

* Fix: Prevent AuthManager state pollution on connection verification

Modified `ConnectViewModel.connect()` to construct a temporary OkHttpClient and Retrofit builder, isolated from the global `ApiClient` state. The connection verification is executed using this temporary service. Only upon a successful HTTP response does the system persist the configured `host`, `port`, and `token` to the global `AuthManager` and triggers an `ApiClient.rebuild()`. This resolves the issue where a failed connection attempt would overwrite active and verified profiles. Extracted `createTempService` factory to `ApiClient` for robustness and clean tests.

Fixes #260

* Fix: Prevent AuthManager state pollution on connection verification

Modified `ConnectViewModel.connect()` to construct a temporary OkHttpClient and Retrofit builder, isolated from the global `ApiClient` state. The connection verification is executed using this temporary service. Only upon a successful HTTP response does the system persist the configured `host`, `port`, and `token` to the global `AuthManager` and triggers an `ApiClient.rebuild()`. This resolves the issue where a failed connection attempt would overwrite active and verified profiles. Extracted `createTempService` factory to `ApiClient` for robustness and clean tests.

Fixes #260

---------

Co-authored-by: M57 <hy4ri@users.noreply.github.com>

app/src/test/java/com/m57/hermescontrol/ui/connect/ConnectViewModelTest.kt

@@ -48,6 +48,7 @@ class ConnectViewModelTest {
 
         mockApiService = mockk()
         every { ApiClient.hermesApi } returns mockApiService
+        every { ApiClient.createTempService(any(), any(), any()) } returns mockApiService
         every { ApiClient.rebuild() } returns Unit
 
         // Default AuthManager stubs
@@ -219,35 +220,6 @@ class ConnectViewModelTest {
             viewModel.connect()
             advanceUntilIdle()
 
-            verify { AuthManager.setToken(null) }
-
-            val state = viewModel.uiState.value
-            assertFalse(state.isConnecting)
-            assertFalse(state.connectionSuccess)
-            assertEquals("Invalid token (401 Unauthorized)", state.errorMessage)
-        }
-
-    @Test
-    fun testConnect_failure_unauthorized_clearsProfileToken() =
-        runTest {
-            every { AuthManager.getSelectedProfileId() } returns "prof-1"
-
-            val viewModel = ConnectViewModel(mockApp)
-            viewModel.onTokenChange("invalid-token")
-            viewModel.onHostChange("127.0.0.1")
-            viewModel.onPortChange("9119")
-
-            val mockResponse = mockk<Response<StatusResponse>>()
-            every { mockResponse.isSuccessful } returns false
-            every { mockResponse.code() } returns 401
-            coEvery { mockApiService.getStatus() } returns mockResponse
-
-            viewModel.connect()
-            advanceUntilIdle()
-
-            verify { AuthManager.setToken(null) }
-            verify { AuthManager.setProfileToken("prof-1", null) }
-
             val state = viewModel.uiState.value
             assertFalse(state.isConnecting)
             assertFalse(state.connectionSuccess)
@@ -612,14 +584,12 @@ class ConnectViewModelTest {
             val viewModel = ConnectViewModel(mockApp)
             viewModel.onPairingString("hermes://connect?host=192.168.1.1&port=8888&token=abc123")
 
-            // Wait for parsing coroutine to finish
-            advanceUntilIdle()
-
             val state = viewModel.uiState.value
             assertEquals("192.168.1.1", state.host)
             assertEquals("8888", state.port)
             assertEquals("abc123", state.token)
             // Should have triggered connect
+            advanceUntilIdle()
             assertTrue("connection should succeed after pairing", viewModel.uiState.value.connectionSuccess)
         }
 }