feat(chat): subtle tool-call divider every 5 calls per turn (#769)

Co-authored-by: M57 <hy4ri@users.noreply.github.com>
2026-08-02 15:22:29 +03:00
1 parent 1e8c3629f0
commit ec72ed4733
@@ -0,0 +1,97 @@
+package com.m57.hermescontrol.ui.chat
+
+import org.junit.Assert.assertEquals
+import org.junit.Assert.assertTrue
+import org.junit.Test
+
+class ChatListEntriesTest {
+    private fun toolMessage() = ChatMessage(role = MessageRole.TOOL, content = "")
+
+    private fun textMessage() = ChatMessage(role = MessageRole.ASSISTANT, content = "hello")
+
+    private fun userMessage() = ChatMessage(role = MessageRole.USER, content = "hi")
+
+    @Test
+    fun emptyListHasNoMilestones() {
+        assertTrue(toolCallMilestones(emptyList()).isEmpty())
+    }
+
+    @Test
+    fun noToolMessagesHasNoMilestones() {
+        val messages = List(8) { textMessage() }
+        assertTrue(toolCallMilestones(messages).isEmpty())
+    }
+
+    @Test
+    fun fewerThanFiveToolCallsHasNoMilestones() {
+        val messages = List(4) { toolMessage() }
+        assertTrue(toolCallMilestones(messages).isEmpty())
+    }
+
+    @Test
+    fun fifthToolCallIsAMilestone() {
+        val messages = List(5) { toolMessage() }
+        assertEquals(mapOf(4 to 5), toolCallMilestones(messages))
+    }
+
+    @Test
+    fun milestoneAtEveryFifthToolCallWithinTurn() {
+        val messages = List(12) { toolMessage() }
+        assertEquals(mapOf(4 to 5, 9 to 10), toolCallMilestones(messages))
+    }
+
+    @Test
+    fun counterResetsAtEachUserMessage() {
+        val messages =
+            listOf(
+                userMessage(), // index 0 — turn 1 starts
+                toolMessage(), // 1
+                toolMessage(), // 2
+                toolMessage(), // 3
+                toolMessage(), // 4
+                toolMessage(), // 5 ← 5th tool call of turn 1
+                userMessage(), // 6 — turn 2 starts, counter resets
+                toolMessage(), // 7
+                toolMessage(), // 8
+                toolMessage(), // 9
+                toolMessage(), // 10
+                toolMessage(), // 11 ← 5th tool call of turn 2 (not 10)
+            )
+        assertEquals(mapOf(5 to 5, 11 to 5), toolCallMilestones(messages))
+    }
+
+    @Test
+    fun nonToolMessagesDoNotCountAndShiftIndices() {
+        val messages =
+            listOf(
+                textMessage(), // index 0
+                toolMessage(), // 1
+                toolMessage(), // 2
+                textMessage(), // 3
+                toolMessage(), // 4
+                toolMessage(), // 5
+                textMessage(), // 6
+                toolMessage(), // 7 ← 5th tool call
+            )
+        assertEquals(mapOf(7 to 5), toolCallMilestones(messages))
+    }
+
+    @Test
+    fun toolMessagesWithoutToolNameStillCount() {
+        val messages = List(5) { ChatMessage(role = MessageRole.TOOL, content = "", toolName = null) }
+        assertEquals(mapOf(4 to 5), toolCallMilestones(messages))
+    }
+
+    @Test
+    fun labelIncludesRealMaxWhenKnown() {
+        assertEquals("5/90", toolCallDividerLabel(count = 5, maxPerTurn = 90))
+        assertEquals("10/90", toolCallDividerLabel(count = 10, maxPerTurn = 90))
+    }
+
+    @Test
+    fun labelDegradesToBareCountWhenMaxUnknown() {
+        assertEquals("5", toolCallDividerLabel(count = 5, maxPerTurn = null))
+        assertEquals("5", toolCallDividerLabel(count = 5, maxPerTurn = 0))
+        assertEquals("5", toolCallDividerLabel(count = 5, maxPerTurn = -1))
+    }
+}