yilsem/aiturk-mobil
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 6 Wiki Activity

feat(#538): wire tool.progress/generating + subagent.* events into chat (#567)

Browse Source 
* feat(#538): wire tool.progress/generating + subagent.* events into chat

* fix(#538): remove subagent indicator on subagent.complete so it doesn't linger

* style(#538): drop dead Elvis on non-nullable event.text in onMessageComplete

---------

Co-authored-by: M57 <m57@hermes-control.app>
This commit is contained in:
M57andM57 authored and GitHub committed 2026-07-12 22:06:32 +03:00
1 parent 9e10c813d4
commit ee28ee5ce2
9 files changed
+592 -2
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

app/src/test/java/com/m57/hermescontrol/ui/chat/ChatWsEventReducerTest.kt
+236
View File
@@ -0,0 +1,236 @@
package com.m57.hermescontrol.ui.chat
import com.m57.hermescontrol.data.ws.WsEvent
import org.junit.Assert.assertEquals
import org.junit.Test
class ChatWsEventReducerTest {
@Test
fun testToolProgress_updatesProgressPreviewForMatchingRunningTool() {
val initialMessage =
ChatMessage(
role = MessageRole.TOOL,
content = "{}",
toolName = "web_search",
toolStatus = ToolStatus.RUNNING,
)
val state =
ChatUiState(
messages = listOf(initialMessage),
currentSessionId = "session-1",
)
val event =
WsEvent.ToolProgress(
name = "web_search",
preview = "fetching google...",
sessionId = "session-1",
)
val result =
ChatWsEventReducer.reduce(
state = state,
streamingState = StreamingState(),
event = event,
currentSessionId = "session-1",
)
assertEquals(1, result.state.messages.size)
val updatedMessage = result.state.messages.first()
assertEquals(ToolStatus.RUNNING, updatedMessage.toolStatus)
assertEquals("fetching google...", updatedMessage.progressPreview)
}
@Test
fun testToolGenerating_clearsProgressPreviewForMatchingRunningTool() {
val initialMessage =
ChatMessage(
role = MessageRole.TOOL,
content = "{}",
toolName = "code_writer",
toolStatus = ToolStatus.RUNNING,
progressPreview = "writing...",
)
val state =
ChatUiState(
messages = listOf(initialMessage),
currentSessionId = "session-1",
)
val event =
WsEvent.ToolGenerating(
name = "code_writer",
sessionId = "session-1",
)
val result =
ChatWsEventReducer.reduce(
state = state,
streamingState = StreamingState(),
event = event,
currentSessionId = "session-1",
)
assertEquals(1, result.state.messages.size)
val updatedMessage = result.state.messages.first()
assertEquals(ToolStatus.RUNNING, updatedMessage.toolStatus)
assertEquals("", updatedMessage.progressPreview)
}
@Test
fun testSubagentEvent_appendsToSubagentIndicators() {
val state =
ChatUiState(
currentSessionId = "session-1",
subagentIndicators = emptyList(),
)
val event =
WsEvent.SubagentEvent(
type = "subagent.start",
sessionId = "session-1",
payload =
mapOf(
"goal" to "analyze repository",
"task_index" to 2,
"task_count" to 4,
"subagent_id" to "sub-1",
"text" to "analyzing files",
),
)
val result =
ChatWsEventReducer.reduce(
state = state,
streamingState = StreamingState(),
event = event,
currentSessionId = "session-1",
)
assertEquals(1, result.state.subagentIndicators.size)
val indicator = result.state.subagentIndicators.first()
assertEquals("subagent.start", indicator.type)
assertEquals("analyze repository", indicator.goal)
assertEquals(2, indicator.taskIndex)
assertEquals(4, indicator.taskCount)
assertEquals("sub-1", indicator.subagentId)
assertEquals("analyzing files", indicator.text)
}
@Test
fun testSubagentEvent_updatesExistingIndicatorBySubagentId() {
val initialIndicator =
SubagentIndicator(
type = "subagent.start",
goal = "analyze repository",
taskIndex = 1,
taskCount = 4,
subagentId = "sub-1",
text = "starting",
)
val state =
ChatUiState(
currentSessionId = "session-1",
subagentIndicators = listOf(initialIndicator),
)
val event =
WsEvent.SubagentEvent(
type = "subagent.progress",
sessionId = "session-1",
payload =
mapOf(
"task_index" to 2,
"subagent_id" to "sub-1",
"text" to "in progress",
),
)
val result =
ChatWsEventReducer.reduce(
state = state,
streamingState = StreamingState(),
event = event,
currentSessionId = "session-1",
)
assertEquals(1, result.state.subagentIndicators.size)
val indicator = result.state.subagentIndicators.first()
assertEquals("subagent.progress", indicator.type)
assertEquals("analyze repository", indicator.goal)
assertEquals(2, indicator.taskIndex)
assertEquals(4, indicator.taskCount)
assertEquals("sub-1", indicator.subagentId)
assertEquals("in progress", indicator.text)
}
@Test
fun testSubagentComplete_removesIndicator() {
val initialIndicator =
SubagentIndicator(
type = "subagent.start",
goal = "analyze repository",
taskIndex = 1,
taskCount = 4,
subagentId = "sub-1",
text = "starting",
)
val state =
ChatUiState(
currentSessionId = "session-1",
subagentIndicators = listOf(initialIndicator),
)
val event =
WsEvent.SubagentEvent(
type = "subagent.complete",
sessionId = "session-1",
payload =
mapOf(
"subagent_id" to "sub-1",
"status" to "completed",
"summary" to "done",
),
)
val result =
ChatWsEventReducer.reduce(
state = state,
streamingState = StreamingState(),
event = event,
currentSessionId = "session-1",
)
assertEquals(0, result.state.subagentIndicators.size)
}
@Test
fun testSessionMismatch_isIgnored() {
val initialMessage =
ChatMessage(
role = MessageRole.TOOL,
content = "{}",
toolName = "web_search",
toolStatus = ToolStatus.RUNNING,
)
val state =
ChatUiState(
messages = listOf(initialMessage),
currentSessionId = "session-1",
)
val event =
WsEvent.ToolProgress(
name = "web_search",
preview = "fetching google...",
sessionId = "session-different",
)
val result =
ChatWsEventReducer.reduce(
state = state,
streamingState = StreamingState(),
event = event,
currentSessionId = "session-1",
)
assertEquals(1, result.state.messages.size)
val updatedMessage = result.state.messages.first()
assertEquals(ToolStatus.RUNNING, updatedMessage.toolStatus)
assertEquals(null, updatedMessage.progressPreview)
}
}