From f870f96fe00ea35293cab7310a63192c9998832f Mon Sep 17 00:00:00 2001 From: M57 <41645758+Hy4ri@users.noreply.github.com> Date: Mon, 22 Jun 2026 15:11:14 +0300 Subject: [PATCH] fix(#294): document KSP standalone versioning, harden ci-summary reporting - A2: Add inline comment to libs.versions.toml explaining ksp version is standalone per KSP 2.0+ guidance (not kotlinVersion-kspVersion) - A3: Rewrite ci-summary check job to report each dependency's result individually with explicit skipped/cancelled/failure handling Co-authored-by: M57 --- .github/workflows/android.yml | 14 +++++++++++--- gradle/libs.versions.toml | 2 ++ 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/.github/workflows/android.yml b/.github/workflows/android.yml index 31a4221d..95a3a0d4 100644 --- a/.github/workflows/android.yml +++ b/.github/workflows/android.yml @@ -272,9 +272,17 @@ jobs: TEST_RESULT: ${{ needs.unit-tests.result }} BUILD_RESULT: ${{ needs.build.result }} run: | - echo "::notice::ktlint=$KTLINT_RESULT, android-lint=$LINT_RESULT, tests=$TEST_RESULT, build=$BUILD_RESULT" - if [[ "$KTLINT_RESULT" != "success" || "$LINT_RESULT" != "success" || "$TEST_RESULT" != "success" || "$BUILD_RESULT" != "success" ]]; then - echo "::error::One or more CI jobs failed" + FAILED=0 + for entry in "ktlint:$KTLINT_RESULT" "android-lint:$LINT_RESULT" "unit-tests:$TEST_RESULT" "build:$BUILD_RESULT"; do + name="${entry%%:*}" + result="${entry#*:}" + echo "::notice::$name = $result" + if [[ "$result" != "success" ]]; then + FAILED=1 + fi + done + if [[ "$FAILED" -eq 1 ]]; then + echo "::error::CI failed — check individual job logs" exit 1 fi echo "All CI jobs passed ✅" diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml index 4d0f6efc..831314cb 100644 --- a/gradle/libs.versions.toml +++ b/gradle/libs.versions.toml @@ -13,6 +13,8 @@ junit = "4.13.2" junit5 = "5.11.4" junitPlatform = "1.11.4" kotlin = "2.3.20" +# standalone per KSP 2.0+ guidance — NOT kotlinVersion-kspVersion; easy +# to miss during Kotlin upgrades since it no longer tracks the Kotlin version. ksp = "2.3.9" nav3Core = "1.0.1" lifecycleViewmodelNav3 = "2.10.0"